Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47768: Add "--chains NO-CHILDREN" to query-collections #1121

Merged
merged 2 commits into from
Dec 2, 2024
Merged

DM-47768: Add "--chains NO-CHILDREN" to query-collections #1121

merged 2 commits into from
Dec 2, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Nov 22, 2024 •
edited
Loading

Added a --chains NO-CHILDREN mode to the butler query-collections CLI,
which returns results without recursing into CHAINED collections.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

@dhirving
Add --chains NO-CHILDREN to query-collections
165cdd2 
Added a `--chains NO-CHILDREN` mode to the `butler query-collections` CLI,
which returns results without recursing into `CHAINED` collections.
@dhirving
Tweak --chains doc
3e6aac1 
Replace "datasets" with "collections" throughout, since this command has nothing to do with datasets.
@dhirving dhirving marked this pull request as ready for review November 22, 2024 21:13
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (09cb37a) to head (3e6aac1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/daf/butler/script/queryCollections.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files         366      366           
  Lines       48604    48610    +6     
  Branches     5890     5890           
=======================================
+ Hits        43475    43481    +6     
  Misses       3717     3717           
  Partials     1412     1412

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving merged commit 1efb2aa into main Dec 2, 2024
18 of 19 checks passed
@dhirving dhirving deleted the tickets/DM-47768 branch December 2, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirving @timj